Skip to content

C#: Sunset QL based stub generator.#14363

Merged
michaelnebel merged 5 commits intogithub:mainfrom
michaelnebel:csharp/sunsetqlstubgen
Oct 24, 2023
Merged

C#: Sunset QL based stub generator.#14363
michaelnebel merged 5 commits intogithub:mainfrom
michaelnebel:csharp/sunsetqlstubgen

Conversation

@michaelnebel
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel commented Oct 3, 2023

  • Sunset the QL based C# stub generator; This also means deleting the make_stubs.py script. Do we still need something similar to that or is it premature to delete the Code QL stub generator completely?
  • Update the readme file with stub generation instructions.

@michaelnebel michaelnebel marked this pull request as ready for review October 3, 2023 11:12
@michaelnebel michaelnebel requested a review from a team as a code owner October 3, 2023 11:12
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Oct 3, 2023
Copy link
Copy Markdown
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one request.

python make_stubs_nuget.py Newtonsoft.Json latest
python make_stubs_nuget.py Newtonsoft.Json 13.0.1
python make_stubs_nuget.py Newtonsoft.Json 13.0.1 /Users/tmp/working-dir
python3 make_stubs_nuget.py classlib Newtonsoft.Json
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot to update this. I think a more natural place for this file (and make_stubs_nuget.py) is something like csharp/scripts/stubs.

@michaelnebel michaelnebel force-pushed the csharp/sunsetqlstubgen branch from 0038c70 to e799cfa Compare October 13, 2023 12:59
@michaelnebel michaelnebel requested a review from a team as a code owner October 13, 2023 13:24
@michaelnebel michaelnebel force-pushed the csharp/sunsetqlstubgen branch from 255468c to 743be92 Compare October 23, 2023 13:16
@michaelnebel michaelnebel requested a review from hvitved October 24, 2023 07:18
@michaelnebel michaelnebel merged commit 26f7670 into github:main Oct 24, 2023
@michaelnebel michaelnebel deleted the csharp/sunsetqlstubgen branch October 24, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# documentation no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants