Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPP: Add test demonstrating use-after-free false negatives. #14568

Merged
merged 1 commit into from Oct 24, 2023
Merged

CPP: Add test demonstrating use-after-free false negatives. #14568

merged 1 commit into from Oct 24, 2023
+40 −0

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Oct 23, 2023

These demonstrate the lack of handling of structs.

@alexet alexet requested a review from MathiasVP October 23, 2023 15:38
@github-actions github-actions bot added the C++ label Oct 23, 2023
MathiasVP
MathiasVP reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the exception of one wrong test annotation

cpp/ql/test/query-tests/Critical/MemoryFreed/test_free.cpp Outdated
void test_free_struct4(char* buf, MyStruct s) {
free(buf);
s.buf = buf;
char c = s.buf[0]; // BAD [FALSE NEGATIVE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't a false negative, though, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@alexet alexet marked this pull request as ready for review October 23, 2023 16:02
@alexet alexet requested a review from a team as a code owner October 23, 2023 16:02
MathiasVP
MathiasVP approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 9652679 into github:main Oct 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexet @MathiasVP