Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo ('Configration' to ‘Configuration’) #14539

Merged
merged 2 commits into from Oct 20, 2023
Merged

Conversation

flyboss
Copy link
Contributor

@flyboss flyboss commented Oct 19, 2023

fix typo ('Configration' to ‘Configuration’)

@flyboss flyboss requested a review from a team as a code owner October 19, 2023 02:36
@github-actions github-actions bot added the JS label Oct 19, 2023
@flyboss flyboss changed the title Main fix typo ('Configration' to ‘Configuration’) Oct 19, 2023
@erik-krogh erik-krogh added no-change-note-required This PR does not need a change note external-contribution labels Oct 19, 2023
erik-krogh
erik-krogh previously approved these changes Oct 19, 2023
@@ -12,8 +12,8 @@ import semmle.javascript.security.TaintedObject
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
/** DEPRECATED: Mis-spelled class name, alias for Configuration. */
deprecated class Configration = Configuration;
/**

Could you add this deprecated alias?
Just in case anyone depends on the misspelled name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course.

add a deprecated alias in case anyone depends on the misspelled name.
@erik-krogh erik-krogh merged commit f562d53 into github:main Oct 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants