Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update working-with-the-npm-registry.md #29255

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Update working-with-the-npm-registry.md #29255

merged 3 commits into from
Oct 20, 2023

Conversation

filiptammergard
Copy link
Contributor

@filiptammergard filiptammergard commented Oct 19, 2023 •
edited
Loading

It should be lodash rather than @lodash. You can't install @lodash.

Why: Package name fix

Closes: I have not created an issue for it since it's only a one-letter change. If you can't accept this PR because there's no related issue, feel free to close the PR. Just trying to help out.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changed from @lodash to lodash, since @lodash is not the accurate name of the package.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@filiptammergard
Update working-with-the-npm-registry.md
0378874 
It should be `lodash` rather than `@lodash`. You can't install `@lodash`.
@welcome
Copy link

welcome bot commented Oct 19, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
packages/working-with-a-github-packages-registry/working-with-the-npm-registry.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
 fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@filiptammergard Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review packages This issue or pull request should be reviewed by the docs packages team and removed triage Do not begin working on this issue until triaged by the team labels Oct 19, 2023
@mchammer01 mchammer01 self-requested a review October 20, 2023 08:30
mchammer01
mchammer01 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filiptammergard - thanks for fixing this ✨
LGTM :shipit:

@mchammer01 mchammer01 enabled auto-merge October 20, 2023 08:33
@mchammer01 mchammer01 added this pull request to the merge queue Oct 20, 2023
Merged via the queue into github:main with commit 7b27a00 Oct 20, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@mchammer01 mchammer01 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 20, 2023
@t5h2i0tadi

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@filiptammergard @cmwilson21 @t5h2i0tadi @mchammer01