Skip to content

Update README link in development.md#29166

Merged
jhosman merged 3 commits intogithub:mainfrom
Harshdev098:patch-2
Oct 16, 2023
Merged

Update README link in development.md#29166
jhosman merged 3 commits intogithub:mainfrom
Harshdev098:patch-2

Conversation

@Harshdev098
Copy link
Copy Markdown
Contributor

@Harshdev098 Harshdev098 commented Oct 15, 2023

Why:

a link in READMEs section of development.md is not working

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 15, 2023
@DanyRaby5008

This comment was marked as spam.

@cmwilson21
Copy link
Copy Markdown
Contributor

@Harshdev098 Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 16, 2023
Copy link
Copy Markdown
Contributor

@jhosman jhosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and for opening a PR with a fix!

I’ve made an additional update, so that it links to the new location in the src directory. (You can see the commit a few months ago where we fixed this in the main README file, but we forgot to make those same changes in development.md.)

We'll go ahead and get this merged for you once tests are passing! 🚀

@jhosman jhosman added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 16, 2023
@jhosman jhosman enabled auto-merge October 16, 2023 22:02
@jhosman jhosman added this pull request to the merge queue Oct 16, 2023
Merged via the queue into github:main with commit 2a3f26c Oct 16, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants