ReDoS: use the new codePointAt and codePointCount methods instead of regex hacks #14481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoff
reviewed
Oct 12, 2023
There was a problem hiding this comment.
- Excellent comment in
getCodePointAtit made all the mysterious components clear 💪 . - Good that you rewrote
escapeUnicodeStringto avoid ranking 👍 - There are a number of calls in
NfaUtilsof the formgetCodePointAt(..., _). It seems that exposing a predicategetACodePoint(string s) { result = s.codePointAt(_).toUnicode() }could avoid ranking for those cases.
be5a583
to
fa1e8ee
Compare
|
Evaluations look good: Java, JavaScript, Python, Ruby. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure what to put as the first word in the title of this PR.
It's shared code in the
shared/folder, but it's only used by the ReDoS libraries.I've put the Python team as reviewers, because they motivated the work.
The codePointAt and codePointCount methods and very new, but they've been in the language for a few weeks by now.
(The PR was merged about a month ago).
I've added documentation for the new string methods to our language specification.