Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install public headers in the standard path #288

Merged
merged 1 commit into from Mar 16, 2017

Conversation

@yan12125
Copy link
Contributor

@yan12125 yan12125 commented Nov 13, 2016

As title, install ffi.h and ffitarget.h to the standard path $PREFIX/include instead of mysterious $PREFIX/lib/libffi-x.y.z/include

@yan12125
Copy link
Contributor Author

@yan12125 yan12125 commented Nov 13, 2016

Mac tests failed. One is related to travis-ci/travis-ci#6522 while I don't known why another fails. I don't have a working Mac so I can't test

@tromey
Copy link
Member

@tromey tromey commented Nov 14, 2016

I think this patch should probably be discussed on the list; the patch itself seems ok but the question is whether this is the desired direction. I don't actually know the rationale for the current approach.

@yan12125
Copy link
Contributor Author

@yan12125 yan12125 commented Nov 15, 2016

Thanks. Is libffi-discuss the correct list for discussion about such a
change?

On Nov 15, 2016 03:32, "Tom Tromey" notifications@github.com wrote:

I think this patch should probably be discussed on the list; the patch
itself seems ok but the question is whether this is the desired direction.
I don't actually know the rationale for the current approach.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#288 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB2RGQzldbBeH4BQpfn_tjUMU6h5KyjHks5q-Lc4gaJpZM4Kwqvm
.

@tromey
Copy link
Member

@tromey tromey commented Nov 15, 2016

Yes, libffi-discuss. Thanks.

@yan12125
Copy link
Contributor Author

@yan12125 yan12125 commented Nov 22, 2016

Seems nobody on libffi-discuss is interested in this :/
https://sourceware.org/ml/libffi-discuss/2016/msg00053.html

yan12125 added a commit to yan12125/python3-android that referenced this pull request Dec 6, 2016
And drop unnecessary libffi patch 288
(libffi/libffi#288)
@jakirkham
Copy link

@jakirkham jakirkham commented Dec 29, 2016

Any thoughts on this? The change here is the correct way to handle header installation. What is controversial about it? Maybe those wishing to maintain the current behavior could advocate for it so we could understand the value.

@yan12125
Copy link
Contributor Author

@yan12125 yan12125 commented Dec 29, 2016

There's nothing controversial. Instead, there are no real discussions about this. I consider libffi semi-dead - there's no development activity (mailing list posts, new commits) for almost two months! For those who need this patch, I'm afraid that the only way is maintaining a private copy of libffi and adding whatever necessary patches.

@tromey
Copy link
Member

@tromey tromey commented Dec 30, 2016

Yes, I was hoping for someone to reply on libffi-discuss to explain why the current setup is needed. But nobody did :(. I will see if I can find more information through some other channel. FWIW I'm generally in favor of making libffi's configury less weird; and making this change is one of the things I'd do.

@atgreen atgreen merged commit 5b91bbd into libffi:master Mar 16, 2017
0 of 2 checks passed
0 of 2 checks passed
ci/circleci No test commands were found
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@yan12125 yan12125 deleted the yan12125:std-includedir branch Mar 16, 2017
yan12125 added a commit to yan12125/python3-android that referenced this pull request Apr 24, 2017
Not necessary after libffi/libffi#288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.