Skip to content

Update managing-multiple-accounts.md#28447

Merged
meowius merged 4 commits intogithub:mainfrom
nodescout:patch-1
Sep 29, 2023
Merged

Update managing-multiple-accounts.md#28447
meowius merged 4 commits intogithub:mainfrom
nodescout:patch-1

Conversation

@nodescout
Copy link
Contributor

Updating the Windows shell command "credential-manager erase" to "credential-manager-core erase". On Windows, the former returns "git: 'credential-manager' is not a git command."

Why:

The current command to clear the credential manager store is incorrect for Windows. It produces an error git: 'credential-manager' is not a git command. See 'git --help'.

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changing the following:
echo "protocol=https`nhost=github.com" | git credential-manager erase

-to-

echo "protocol=https`nhost=github.com" | git credential-manager-core erase

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Updating the windows shell command "credential-manager erase" to "credential-manager-core erase". On windows, the former returns "git: 'credential-manager' is not a git command."
@welcome
Copy link

welcome bot commented Sep 23, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-personal-account/managing-multiple-accounts.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Valecia2023

This comment was marked as spam.

@cmwilson21
Copy link
Contributor

@nodescout Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review using git Content related to using git account-and-profile Content relating to account and profile and removed triage Do not begin working on this issue until triaged by the team labels Sep 25, 2023
@meowius meowius added the needs SME This proposal needs review from a subject matter expert label Sep 25, 2023
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@meowius
Copy link
Contributor

meowius commented Sep 25, 2023

@nodescout Thanks so much for flagging this and taking the time to open a PR. I have a clarification for you from our Git team that requires a small edit to this PR if you're willing.

Context: the correct command depends on which version of Git and Git Credential Manager you have installed.

That means making a different edit to "Managing multiple accounts."

Leave the resuable you edited as is (i.e., leave it as git credential-manager erase and do not update to git credential-manager-core erase).

Instead, update the bullet preceding the reusable from this, as it reads currently:

If the output is manager-core, you're using Git Credential Manager. To clear the credentials, run the following command.

to this, as it should read:

If the output is manager (or manager-core in previous versions), you’re using Git Credential Manager.

Let us know if you'd be willing to update this PR to reflect this. Thank you!

@meowius meowius added SME reviewed An SME has reviewed this issue/PR and removed needs SME This proposal needs review from a subject matter expert labels Sep 25, 2023
@cmwilson21 cmwilson21 added the more-information-needed More information is needed to complete review label Sep 26, 2023
Updated the reusable component to clarify the usage of Git Credential Manager as per feedback on PR #28447. This change reflects the correct command based on the version of Git and Git Credential Manager installed, as discussed in [PR #28447](#28447).
…tead

Reverted the changes made to managing-multiple-accounts.md as the necessary updates were made in a reusable component to address the feedback on Git Credential Manager usage. The relevant modifications have been made in the reusable component via commit [7f1eabd](https://github.com/nodescout/docs/commit/7f1eabd4e4d8e7f98d67fe379bf4b4ce704562ad).
@nodescout
Copy link
Contributor Author

Hi @meowius,

I have made the requested updates to address the feedback regarding the Git Credential Manager usage. Instead of modifying the managing-multiple-accounts.md file directly, I updated the reusable component that contains the relevant information. The changes can be seen in commit 7f1eabd. Additionally, I reverted the original changes made to managing-multiple-accounts.md as they are no longer necessary with the updated reusable component.

Please review the updates at your convenience and let me know if there are any further changes needed. Thank you for your feedback and guidance on this!

@cmwilson21 cmwilson21 removed the more-information-needed More information is needed to complete review label Sep 27, 2023
@meowius
Copy link
Contributor

meowius commented Sep 29, 2023

Brilliant @nodescout, thanks so much for catching that this was part of a reusable and making the update. I"ll get this merged. Really appreciate your making the docs better for everyone! ⚡

Copy link
Contributor

@meowius meowius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@meowius meowius added this pull request to the merge queue Sep 29, 2023
Merged via the queue into github:main with commit bf00f3d Sep 29, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team SME reviewed An SME has reviewed this issue/PR using git Content related to using git waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants