New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of respecting $PSStyle.OutputRendering on the remote host
#19601
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 Handy links: |
PR Summary
Using PowerShell remoting, if you set
$PSStyle.OutputRendering = 'plaintext'on the remote side, ANSI escape sequences are still being sent over the wire. Change is in the RemoteHostUserInterface using theGetOutputString()method to determine and strip ANSI escape sequences if required. Since this interface doesn't detect or support indicating if VirtualTerminal is supported, we always assume so so that ANSI can still be sent.Tested manually using
Enter-PSHostProcess.PR Context
Reported by Microsoft partner that ANSI is still being sent over the wire via PSRP even if
$PSStyle.OutputRendering = 'plaintext'is set in the remote server side. This is because only the local host was checking if ANSI should be removed. This change uses the same method.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).