Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release pipeline to use Approvals and automate some manual tasks #17837

Merged
merged 16 commits into from Aug 8, 2022
Merged

Update release pipeline to use Approvals and automate some manual tasks #17837

merged 16 commits into from Aug 8, 2022

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Aug 3, 2022 •
edited

PR Summary

  1. Update the task based on environment approval to use Manual tasks
  2. Automate kicking off builds for release automation, vpack and snap
  3. Automate adding change log to the GitHub release draft.

PR Context

PR Checklist

JamesWTruher
JamesWTruher approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks fine, but the wait cmdlet will emit progress

tools/releaseBuild/azureDevOps/releasePipeline.yml Show resolved Hide resolved
tools/releaseBuild/azureDevOps/releasePipeline.yml Outdated
Set-AzDoProjectInfo -ProjectOwner PowerShell-Rel -ProjectName Release-Automation
$metadata = Get-Content -Raw -Path '$(Pipeline.Workspace)/releasePipeline/metadata/release.json' | ConvertFrom-Json
$azDOBuild = Get-AzDOBuild -buildDefinitionId 10 -MaximumResult 100 | Where-Object { $_.tags -contains $metadata.ReleaseVersion }
$azDoBuild | Remove-AzDOBuildTag -tag 'InProgress' -Pass | Add-AzDOBuildTag -Id $azDOBuild.Id -tag 'SignedOff'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a check for the job being complete?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for completion in above task

tools/releaseBuild/azureDevOps/releasePipeline.yml Outdated Show resolved Hide resolved
tools/releaseBuild/azureDevOps/templates/release-CreateGitHubDraft.yml Show resolved Hide resolved
@msftbot msftbot bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 8, 2022
@msftbot msftbot bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 8, 2022
@adityapatwardhan adityapatwardhan marked this pull request as ready for review August 8, 2022 18:04
@pull-request-quantifier
Copy link

This PR has 291 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +240 -51
Percentile : 69.1%

Total files changed: 3

Change summary by file extension:
.yml : +240 -51

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit 2eed0f5 into PowerShell:master Aug 8, 2022
15 checks passed
@adityapatwardhan adityapatwardhan deleted the ManualTasks branch August 8, 2022 18:56
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 8, 2022
@msftbot
Copy link

msftbot bot commented Aug 11, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.🎉

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
@TravisEz13
Copy link
Member

Shouldn't be a full backport, but only of the manual approval changes

daxian-dbw pushed a commit that referenced this pull request Apr 7, 2023
Merged PR 24413: Add pipeline secrets (from #17837)
11af035
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Apr 12, 2023
@adityapatwardhan @daxian-dbw
Update release pipeline to use Approvals and automate some manual tas…
61465c9 
…ks (PowerShell#17837)
@msftbot
Copy link

msftbot bot commented Apr 13, 2023

🎉v7.2.11 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher JamesWTruher approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@PaulHigin PaulHigin PaulHigin approved these changes

@daxian-dbw daxian-dbw

@anmenaga anmenaga

Assignees

@adityapatwardhan adityapatwardhan

Labels
Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@adityapatwardhan @TravisEz13 @JamesWTruher @PaulHigin @daxian-dbw @iSazonov