Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: Route compiler diagnostics through our log. #14052

Merged
merged 2 commits into from Aug 25, 2023
Merged

Swift: Route compiler diagnostics through our log. #14052

merged 2 commits into from Aug 25, 2023

Conversation

sashabu
Copy link
Contributor

@sashabu sashabu commented Aug 24, 2023

Fixed version of #13869, which was reverted in #13917.

@github-actions github-actions bot added the Swift label Aug 24, 2023
@sashabu sashabu marked this pull request as ready for review August 25, 2023 12:26
@sashabu sashabu requested a review from a team as a code owner August 25, 2023 12:26
AlexDenisov
AlexDenisov approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@AlexDenisov AlexDenisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as DCA is happy :shipit:

@sashabu
Copy link
Contributor Author

sashabu commented Aug 25, 2023

LGTM as long as DCA is happy :shipit:

Dimillian__MovieSwiftUI is timing out both before and after, even after a dca retry. Other than that, I think it looks good.

@AlexDenisov AlexDenisov merged commit 0fe7740 into main Aug 25, 2023
14 checks passed
@AlexDenisov AlexDenisov deleted the sashabu/swift-logging-compiler branch August 25, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexDenisov AlexDenisov AlexDenisov approved these changes

@redsun82 redsun82 Awaiting requested review from redsun82

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sashabu @AlexDenisov @redsun82