You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst reviewing #13938, it occurred to me that we don't include the read/store steps used to model flow into (hash) splat parameters in type tracking. This PR does that, but a bit differently, as we use type tracking's ability to define read-store steps, to avoid having SynthSplatParameterElementNodes be LocalSourceNodes.
It looks like the DCA run failed - it would be good to see a passing run for this change. I'd also be interested to know: do we expect this to result in any change in analysis results? Presumably only for queries which rely on type tracking rather than full data flow?
It looks like the DCA run failed - it would be good to see a passing run for this change. I'd also be interested to know: do we expect this to result in any change in analysis results? Presumably only for queries which rely on type tracking rather than full data flow?
The first DCA run is successful; the second fails with Cannot create a string longer than 0x1fffffe8 characters because meta queries are enabled (I believe @esbena is already aware of this). Regarding analysis results: Yes, we can expect different analysis results, because type tracking is used to construct the call graph.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst reviewing #13938, it occurred to me that we don't include the read/store steps used to model flow into (hash) splat parameters in type tracking. This PR does that, but a bit differently, as we use type tracking's ability to define read-store steps, to avoid having
SynthSplatParameterElementNodes beLocalSourceNodes.