Python/JavaScript: Shared module for serverless functions #13729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
reviewed
Jul 12, 2023
3d9d685
to
dc0282d
Compare
made space for other serverless frameworks in the directory `serverless`
Modelled on the javascript serverless module, but - The predicate that reports YAML files is now public so languages can implement their own file conventions. - It also reports framework and runtime. - The conveninece predicates with files still exist, but they only report the path. - Handler mapping conventions are now documented. - Use parameterised serverless module in Python, tests now pass.
a867c37
to
02c41f3
Compare
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
alexrford
previously approved these changes
Jul 23, 2023
| * Gets a string suitable as part of a file path. | ||
| */ | ||
| bindingset[base] | ||
| private string normalise(string base) { result = removeLeadingDotSlash(removeTrailingDot(base)) } |
There was a problem hiding this comment.
Should be US spelling normalize. Also maybe a more descriptive name, e.g. normalizePath?
There was a problem hiding this comment.
Yeah, that is a better name :-)
Comment on lines
103
to
105
| if exists(properties.lookup("CodeUri")) | ||
| then codeUri = normalise(lookupValue(properties, "CodeUri")) | ||
| else codeUri = "" |
There was a problem hiding this comment.
This "if property exists then lookup the value, else """ pops up a few times in this predicate (also on L108 and L123) - maybe worth factoring out into a little helper predicate.
Co-authored-by: Alex Ford <alexrford@users.noreply.github.com>
- rename `normalise` to `normalizePath` - factor out `lookupValueOrEmpty`
alexrford
requested changes
Jul 25, 2023
Co-authored-by: Alex Ford <alexrford@users.noreply.github.com>
alexrford
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, we find 2 command injections in DVSA.