C++: Fix barriers in invalid pointer deref #13725
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review recommended.
and here it makes sense that every dataflow node guarded by the
safe(s)condition is safe because there's presumably no way to turnsunsafe again. However, when we're reasoning about buffer overflows, simply having a check likeif(i < size)doesn't mean that there's not aa[i + 100000000] = 0somewhere inside the block that's guarded byif(i < size). Andi + 100000000very likely isn't safe even thoughi < size.InvalidPointerToDerefBarrier::BarrierConfig, but this is needlessly complex and doesn't seem to give any additional performance boosts.This will conflict with #13699, but it shouldn't be difficult to handle the resulting merge-conflict.