C#: Turn RuntimeVersion into a record type. #13688

michaelnebel · 2023-07-07T13:25:51Z

No description provided.

tamasvajk · 2023-07-11T12:21:03Z

csharp/extractor/Semmle.Extraction.CSharp.Standalone/Runtime.cs

@@ -22,7 +22,7 @@ internal partial class Runtime

        public Runtime(IDotNet dotNet) => this.dotNet = dotNet;

-        internal sealed class RuntimeVersion : IComparable<RuntimeVersion>
+        internal record RuntimeVersion : IComparable<RuntimeVersion>


@michaelnebel Somewhat independently from this change. I think we're not using the IComparable<> anywhere in the application. We seem to rely on the order of the runtimes that the dotnet CLI is returning to us, which happens to be chronological, and therefore we're using the latest installed version.

C#: Turn RuntimeVersion into a record type.

0dabcc8

github-actions bot added the C# label Jul 7, 2023

tamasvajk reviewed Jul 11, 2023

View reviewed changes

C#: Turn RuntimeVersion into a record type. #13688

C#: Turn RuntimeVersion into a record type. #13688

michaelnebel commented Jul 7, 2023

tamasvajk Jul 11, 2023

C#: Turn RuntimeVersion into a record type. #13688

Are you sure you want to change the base?

C#: Turn RuntimeVersion into a record type. #13688

Conversation

michaelnebel commented Jul 7, 2023

tamasvajk Jul 11, 2023

Choose a reason for hiding this comment