Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-node-output-errors #48992

Merged
merged 1 commit into from Aug 3, 2023
Merged

test: refactor test-node-output-errors #48992

merged 1 commit into from Aug 3, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 1, 2023

The main reason is to not have the test fail if the CWD contains some special URL chars.

@aduh95
test: refactor test-node-output-errors
38579e7 
The main reason is to not have the test fail if the CWD contains some
special URL chars.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 1, 2023
@aduh95 aduh95 requested a review from MoLow August 2, 2023 05:40
MoLow
MoLow approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 2, 2023
@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/53036/

@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/53039/

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 2, 2023
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Open
29 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 3, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3af7cfe into nodejs:main Aug 3, 2023
65 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 3af7cfe

@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Open
25 tasks
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@aduh95 @pluris
test: refactor test-node-output-errors
a2fa998 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@aduh95 @pluris
test: refactor test-node-output-errors
db59667 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
test: refactor test-node-output-errors
681f392 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@aduh95 @Ceres6
test: refactor test-node-output-errors
a578ea4 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@aduh95 @UlisesGascon
test: refactor test-node-output-errors
92226a8 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
test: refactor test-node-output-errors
a4170a0 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: #48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@aduh95 @RafaelGSS
test: refactor test-node-output-errors
1e476ae 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@aduh95 @rluvaton
test: refactor test-node-output-errors
f628e10 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: nodejs#48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@aduh95 @RafaelGSS
test: refactor test-node-output-errors
b3a7427 
The main reason is to not have the test fail if the CWD contains some
special URL chars.

PR-URL: #48992
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aduh95 @nodejs-github-bot @MoLow @atlowChemi