C++: Add IR test that shows dataflow regression after frontend update#13862
Merged
MathiasVP merged 1 commit intogithub:mainfrom Aug 1, 2023
Merged
C++: Add IR test that shows dataflow regression after frontend update#13862MathiasVP merged 1 commit intogithub:mainfrom
MathiasVP merged 1 commit intogithub:mainfrom
Conversation
MathiasVP
approved these changes
Aug 1, 2023
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
This LGTM! But should we maybe put this into the dataflow test folder as well?
Contributor
Author
This is literally one of the dataflow tests 😄 |
Contributor
Author
|
For reference codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/example.c Lines 24 to 26 in 2b3cab3 |
Contributor
|
Oh! I thought this was a new and evil test that you somehow crafted 😂. Yay for our tests then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.