New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Add language-specific baseline configuration #13846
base: main
Are you sure you want to change the base?
Conversation
|
@smowton Note that CI failed because it found Go 1.20.5 in the cache and used that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we modify these scripts to return a JSON object in all cases (for instance, just an empty array for paths-ignore)? Right now the CLI will tolerate the output, but will raise a warning that the script didn't return a valid baseline configuration.
The toolcache version used in an Actions run on a repo isn't monotonic, and can wobble during the rollout of a new version of the toolcache. So it might be an idea to set up a specific patch version of Go, if the tests rely on that. |
|
@henrymercer Sure. Done (though the new commit that I've pushed isn't showing up yet - maybe a short delay?). Note that I wasn't sure whether to put this in |
|
Looking at the Makefile, |
|
I looked at your branch and it looks good, except I think |
fe9c8dd
to
47a536c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built an intree dist for Go and tested this on a repo with vendored modules. After making the modifications below, it worked 🎉:
> codeql database init path/to/db --source-root path/to/source --language go -vvv --calculate-language-specific-baseline
...
Ignored an additional 2516 files when processing baseline information for Go due to paths and paths-ignore configuration.
Found 1254 baseline files for go.
...
Co-authored-by: Henry Mercer <henry.mercer@me.com>
No description provided.