Follow-up CODEOWNERS adjustments #8751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit c09f00b): https://flutter-docs-prod--pr8751-misc-codeowners-adju-mp10e778.web.app (expires Thu, 08 Jun 2023 17:30:34 GMT) Sign: d5ba327eec813901cac8396c4f458b02288624ab |
|
THANKS, @parlough! Yes, that was irritating. |
khanhnwin
reviewed
May 25, 2023
khanhnwin
reviewed
May 25, 2023
|
Added @khanhnwin :) |
|
Unfortunately CODEOWNERS doesn't have a way to allow for approval without automatically requesting reviews as far as I can tell, even if you specify a team. It's frustrating :/ I more and more think we should drop CODEOWNERS in favor of a custom GitHub action. |
khanhnwin
approved these changes
May 25, 2023
|
@domesticmouse do you have any desire to be included on more PRs? :) |
Always happy to help |
atsansone
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It seems like later rules from 23583e6 override the default declared at the top, preventing Shams from approving configuration and root repository files. She needs that access. This PR adjusts the file to return that access.
Also adds Khanh as a code owner for Jekyll plugins and sass files, which aren't often updated, but often need a technical review.