Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md updates #145

Merged
merged 3 commits into from Aug 28, 2018
Merged

Conversation

@omniomi
Copy link
Collaborator

@omniomi omniomi commented Aug 27, 2018

Expanded on CONTRIBUTING.md to include a detailed guide and touched up some wording.

omniomi added 2 commits Aug 27, 2018
@omniomi omniomi requested a review from TylerLeonhardt Aug 27, 2018
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

one single little nit :) LGTM


If installing Atom is not an option or you cannot get it working you can submit a PR with "[WIP]" for Work-In-Progress in the title and our continuous integration tools will run the tests for you.

If you get any errors that were unexpected make sure to fix them and run the tests again. If your change caused a test to break on purpose or if you need to create tests for something entirely new continue to the next section.

This comment has been minimized.

@TylerLeonhardt

TylerLeonhardt Aug 27, 2018
Member

nit: a comma after "if you need to create tests for something entirely new "

This comment has been minimized.

@omniomi

omniomi Aug 27, 2018
Author Collaborator

Added

@TylerLeonhardt TylerLeonhardt merged commit 378e3e8 into PowerShell:master Aug 28, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.