Java: Avoid low-confidence dispatch to InputStream methods #13769
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a neutral model for `InputStream.read`, which offers a high-confidence alternative for this method.
aschackmull
reviewed
Jul 19, 2023
java/ql/lib/ext/java.io.model.yml
Outdated
| @@ -116,6 +116,7 @@ extensions: | |||
| - ["java.io", "File", "isDirectory", "()", "summary", "manual"] | |||
| - ["java.io", "File", "mkdirs", "()", "summary", "manual"] | |||
| - ["java.io", "FileInputStream", "FileInputStream", "(File)", "summary", "manual"] | |||
| - ["java.io", "InputStream", "read", "()", "summary", "manual"] | |||
There was a problem hiding this comment.
Shouldn't this be a taint step from Argument[this] to ReturnValue? IIRC we've defaulted to having small bit-width apis that are technically taint-propagating as taint steps and then rule them out with type-based barriers.
There was a problem hiding this comment.
That'd be my preferred solution, indeed! But I seemed to remember we had agreed on the contrary
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,3,688,205,80,,9,,,18
+ Java Standard Library,``java.*``,3,689,205,80,,9,,,18
- Totals,,283,13606,2067,290,16,122,33,1,391
+ Totals,,283,13607,2067,290,16,122,33,1,391
- java.io,50,,45,,,22,,,,,,,,,,,,,,28,,,,,,,,,,,,,,,,,,,43,2
+ java.io,50,,46,,,22,,,,,,,,,,,,,,28,,,,,,,,,,,,,,,,,,,44,2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
java.io.InputStreamas a valid target class for low-confidence dispatch consideration.Also adds a summary model for
InputStream.read(), which offers a high-confidence alternative for this method.