I think the micro-site docs need to be updated as part to this to say that the library is deprecated (not that we're going to deprecate it at some point). Also some tests will probably fail, because they'll now include a deprecation warning.

I think the micro-site docs need to be updated as part to this to say that the library is deprecated (not that we're going to deprecate it at some point).

Good point. I guess we'll simply change the wording in https://github.com/github/codeql/blob/main/docs/codeql/codeql-language-guides/analyzing-data-flow-in-cpp.rst, right?

Also some tests will probably fail, because they'll now include a deprecation warning.

Yeah, I think it's fine to just accept these. Then we can delete those annotations completely once we delete the library.

I think the micro-site docs need to be updated as part to this to say that the library is deprecated (not that we're going to deprecate it at some point).

Good point. I guess we'll simply change the wording in https://github.com/github/codeql/blob/main/docs/codeql/codeql-language-guides/analyzing-data-flow-in-cpp.rst, right?

Yes.

Also some tests will probably fail, because they'll now include a deprecation warning.

Yeah, I think it's fine to just accept these. Then we can delete those annotations completely once we delete the library.

Agreed.

Oh yeah, coding standards 😭

😭

Coding standards is pinned to a CodeQL CLI and standard library version. What is the expected deprecation timeline. Last time it was around a year I believe.

/cc @lcartey

Coding standards is pinned to a CodeQL CLI and standard library version.

Indeed, but the next branch which we test against isn't, and that's causing problems here. Of course that branch exists to catch these kinds of problems early.

Last time it was around a year I believe.

Correct 🙂

I believe we can move forward with this, and we just have to update the test results on the coding standards next branch to include the deprecation warnings.

I believe we can move forward with this, and we just have to update the test results on the coding standards next branch to include the deprecation warnings.

Thanks for the ping. I'll update the test results on this branch later today 👍.

This PR is ready for a docs review. Documentation friends: Would you please review the changes to the analyzing-data-flow-in-cpp.rst file?