Java: Limit the number of samples extracted in application mode #13730
+36
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the same trick as for the negative examples, this time with a limit of 7 candidates for each endpoint signature. As this duplicates some of the logic used in another query, it may be worthwhile to consider extracting this into a shared parameterized module.
kaeluka
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same trick as for the negative examples, this time with a limit of 9 candidates for each endpoint signature.
On
OpenIdentityPlatform/OpenAM, this resulted in a reduction in results from ~93k to ~14k. (Further reducing the number of candidates per endpoint to 7 would only reduce the number of results by roughly 700).As this duplicates some of the logic used in another query, it may be worthwhile to consider extracting this into a shared parameterized module.
cc: @charisk, @jhelie