New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how isPreview is determined. #19650
Change how isPreview is determined. #19650
Conversation
In release builds, we will don't always label the build as preview, sometimes it's daily. However, if we can't convert the (string) psversion to a System.Version we know we have a preview.
f2d2ec8
to
2cbf4db
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
🎉 Handy links: |
In release builds, we will don't always label the build as preview, sometimes it's "daily". This causes failures in the test where we determine whether we have all the cmdlets we should (and not any extras).
Changing the logic to if we can't convert the (string) psversion to a System.Version we know we have a preview.
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).