Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explicit manual stage for changelog update #19551

Merged
merged 1 commit into from Apr 21, 2023
Merged

Add an explicit manual stage for changelog update #19551

merged 1 commit into from Apr 21, 2023

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Apr 20, 2023 •
edited

PR Summary

Fix #19545

Add an explicit manual stage for changelog update.
The step "create GitHub Draft release" requires the corresponding changelog file gets updated for the release. So, add an explicit manual step before the "Create GitHub draft release" stage in the release pipeline to make the dependency clear.

I have run a release pipeline to validate this change:

image

@daxian-dbw daxian-dbw marked this pull request as ready for review April 20, 2023 19:10
@daxian-dbw daxian-dbw assigned daxian-dbw and unassigned PaulHigin Apr 20, 2023
@daxian-dbw daxian-dbw added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.2.x-Consider Backport-7.3.x-Consider labels Apr 20, 2023
@daxian-dbw daxian-dbw merged commit b4f2e3a into PowerShell:master Apr 21, 2023
16 checks passed
@daxian-dbw daxian-dbw deleted the changelog branch April 21, 2023 00:34
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Apr 25, 2023
@daxian-dbw @TravisEz13
Add an explicit manual stage for changelog update (PowerShell#19551)
b75180b
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Apr 25, 2023
@daxian-dbw @TravisEz13
Add an explicit manual stage for changelog update (PowerShell#19551)
dc0cf72
@TravisEz13 TravisEz13 mentioned this pull request Apr 25, 2023
Merged
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Apr 25, 2023
@daxian-dbw @TravisEz13
Add an explicit manual stage for changelog update (PowerShell#19551)
3f96864
TravisEz13 added a commit that referenced this pull request Apr 26, 2023
@TravisEz13 @daxian-dbw
Add an explicit manual stage for changelog update (#19551) (#19567)
cd753e6 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
adityapatwardhan pushed a commit that referenced this pull request Jun 14, 2023
@daxian-dbw @adityapatwardhan
Add an explicit manual stage for changelog update (#19551)
f135ba4
@msftbot
Copy link

msftbot bot commented Jun 27, 2023

🎉v7.2.12 has been released which incorporates this pull request.🎉

Handy links:

@msftbot msftbot bot mentioned this pull request Jun 27, 2023
Closed
5 tasks
@msftbot
Copy link

msftbot bot commented Jun 27, 2023

🎉v7.3.5 has been released which incorporates this pull request.🎉

Handy links:

@msftbot
Copy link

msftbot bot commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes TravisEz13 is a code owner

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner

@anmenaga anmenaga Awaiting requested review from anmenaga anmenaga is a code owner

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@daxian-dbw daxian-dbw

Labels
Backport-7.2.x-Done Backport-7.3.x-Approved CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The "Create GitHub draft release" stage depends on changelog update to be merged
4 participants
@daxian-dbw @TravisEz13 @adityapatwardhan @PaulHigin