Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git mailmap for Andy Jordan #19469

Merged
merged 1 commit into from Apr 26, 2023
Merged

Add Git mailmap for Andy Jordan #19469

merged 1 commit into from Apr 26, 2023

Conversation

andschwa
Copy link
Member

@andschwa andschwa commented Apr 7, 2023

PR Summary

This makes Git transparently remap commits under my prior name and email to my new name and Microsoft email.

PR Context

I just did this to the extension repo in PowerShell/vscode-powershell#4499 and it works like a treat!

PR Checklist

This makes Git transparently remap commits under my prior name and email
to my new name and Microsoft email.
@andschwa
Copy link
Member Author

Here's the docs for Git mailmap if you're interested.

@msftbot msftbot bot added the Review - Needed The PR is being reviewed label Apr 20, 2023
@msftbot
Copy link

msftbot bot commented Apr 20, 2023

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@andschwa
Copy link
Member Author

@TravisEz13 can you get this reviewed/approved please? It has zero code impact, it's just a piece of information fed to Git to make the log correct.

@msftbot msftbot bot removed the Review - Needed The PR is being reviewed label Apr 24, 2023
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TravisEz13 TravisEz13 merged commit 6e34b1b into master Apr 26, 2023
40 checks passed
@TravisEz13 TravisEz13 deleted the andschwa/mailmap branch April 26, 2023 18:34
@adityapatwardhan adityapatwardhan added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jun 28, 2023
@msftbot
Copy link

msftbot bot commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants