Skip to content

Show indicator when repository is archived#16943

Merged
niik merged 3 commits intodevelopmentfrom
dusty-repositories
Jul 4, 2023
Merged

Show indicator when repository is archived#16943
niik merged 3 commits intodevelopmentfrom
dusty-repositories

Conversation

@niik
Copy link
Copy Markdown
Member

@niik niik commented Jun 21, 2023

Closes #7183

Description

This adds an archived "badge" to archived repository in the clone dialog

Screenshots

image

Release notes

Notes: [Added] Show when a repository has been archived in the clone dialog

Copy link
Copy Markdown
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, but the border has low contrast with the background in the dark theme

flex-shrink: 0;
margin-left: var(--spacing-half);
font-size: var(--font-size-xs);
border: var(--base-border);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border color doesn't look good in dark mode IMO, I would expect a lighter color:

image

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout, I used the contrast border instead, looks much better IMO

image image

@niik niik requested a review from sergiou87 July 4, 2023 11:32
@niik niik enabled auto-merge July 4, 2023 11:32
Copy link
Copy Markdown
Member

@sergiou87 sergiou87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now, thanks for the quick fix! :shipit:

@niik niik merged commit fcd903b into development Jul 4, 2023
@niik niik deleted the dusty-repositories branch July 4, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archived Repositories

2 participants