New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45723: Add --with-pkg-config to configure (GH-29517) #29517

Merged

tiran merged 2 commits into python:main from tiran:bpo-45723-with-pkg-config

Nov 10, 2021

Member

tiran commented Nov 10, 2021 •

edited by bedevere-bot

Let users require or ignore pkg-config. --with-pkg-config makes
pkg-config mandatory. --without-pkg-config disables use of
pkg-config. Disabling is also useful to check how configure behaves
without pkg-config installed.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45723

The text was updated successfully, but these errors were encountered:

the-knights-who-say-ni added the CLA signed label

tiran requested a review from erlend-aasland

bedevere-bot added the awaiting core review label

tiran force-pushed the bpo-45723-with-pkg-config branch 2 times, most recently from e6a5f7e to d0e72b7


          bpo-45723: Add --with-pkg-config to configure

f1bd071

Let users require or ignore pkg-config. ``--with-pkg-config`` makes
pkg-config mandatory. ``--without-pkg-config`` disables use of
pkg-config. Disabling is also useful to check how configure behaves
without pkg-config installed.

Signed-off-by: Christian Heimes <christian@python.org>

tiran force-pushed the bpo-45723-with-pkg-config branch from d0e72b7 to f1bd071

tiran marked this pull request as ready for review

erlend-aasland suggested changes

View changes

Contributor

erlend-aasland left a comment

Looks good. I think a note in Build Changes in What's New would be nice.

configure.ac Outdated Show resolved Hide resolved

configure.ac

  
                if test -z "$PKG_CONFIG"; then

                  dnl invalidate stale config.cache values

                  AS_UNSET([PKG_CONFIG])

                  AS_UNSET([ac_cv_path_ac_pt_PKG_CONFIG])

                  AS_UNSET([ac_cv_prog_ac_ct_PKG_CONFIG])

                fi

Contributor

erlend-aasland Nov 10, 2021

Unsetting PKG_CONFIG and friends if PKG_CONFIG is not set? Is there a missing ! in the test? Is this check needed at all; the config.cache guard is pretty strict.

Member Author

tiran Nov 10, 2021

It's un-declaring the variables when it's empty. This solves a corner case when going from ./configure -C --without-pkg-config to ./configure -C --with-pkg-config=yes.

Member Author

tiran Nov 10, 2021

Maybe you are able to find a better way...

Contributor

erlend-aasland Nov 10, 2021

I see. No, this is fine. I can't think of a better way.

Contributor

erlend-aasland commented Nov 10, 2021

Is it worth it listing the packages we actually use pkg-config to detect?


          Update configure.ac

1ac540d

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

Member Author

tiran commented Nov 10, 2021

Is it worth it listing the packages we actually use pkg-config to detect?

The pkg-config m4 macro will do that for us.

erlend-aasland approved these changes

View changes

tiran changed the title ~~bpo-45723: Add --with-pkg-config to configure~~ bpo-45723: Add --with-pkg-config to configure (GH-29517)

tiran merged commit fc9b622 into python:main

12 checks passed

tiran deleted the bpo-45723-with-pkg-config branch

bedevere-bot removed the awaiting core review label

remykarem added a commit to remykarem/cpython that referenced this issue


          bpo-45723: Add --with-pkg-config to configure (pythonGH-29517)

335d864

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment