Merged
Conversation
asgerf
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly an uneventful upgrade.
The release notes mostly have things that are not relevant for us (better type inference, etc.).
But namespaced attributes in JSX is a new AST feature.
Still depends on an internal PR..All tests pass locally.Internal PR merged, everything green ✅
For the support for namespaced attributes JSX it might look weird that I just "forward" to the inner
"name"attribute.The reason is that which namespace it is doesn't seem important, and it's not part of the JSON object we get from the parser-wrapper.
Here is the full JSON from the parser-wrapper for one of the new attributes in the test: https://gist.github.com/erik-krogh/ec3989af630ba7e11c01ebf6f856ca80.
I could look into whether I can get the name of the namespace to be part of the output, but I don't see that as important.
Evaluation was uneventful.