Skip to content

Conversation

@jcogs33
Copy link
Contributor

@jcogs33 jcogs33 commented May 12, 2023

Description

This PR updates the command-line-injection sink kind to command-injection and the credentials[%] sink kind to credentials-%.

(related Java PR: #12916)

Consideration

Let me know if I missed anything else that needs to be updated.

(cc @asgerf)

@jcogs33 jcogs33 force-pushed the jcogs33/update-javascript-sink-kinds branch from e3be54a to 003bb2f Compare May 16, 2023 19:46
@jcogs33 jcogs33 marked this pull request as ready for review May 16, 2023 20:00
@jcogs33 jcogs33 requested a review from a team as a code owner May 16, 2023 20:00
@jcogs33 jcogs33 requested a review from asgerf May 16, 2023 20:01
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jcogs33
Copy link
Contributor Author

jcogs33 commented May 19, 2023

Thanks for the review @asgerf!
I'll merge this around the same time that I merge #12916 and #13136, hopefully sometime next week.

@jcogs33 jcogs33 merged commit 84a7b3c into github:main Jun 1, 2023
@jcogs33 jcogs33 deleted the jcogs33/update-javascript-sink-kinds branch June 1, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants