This affect Java as well, right?

This affect Java as well, right?

Oh, yes, that's right.
I'll run the tests locally to see if they pass.

Edit: The Java tests are fine, I'll request review from the team.

Was CI not run for Python?

Was CI not run for Python?

Because no file in the python/ folder was touched.
I've run the tests locally, and everything is fine.
You can add the shared/ folder as a path that triggers the Python CI if you want.

Was CI not run for Python?

Because no file in the python/ folder was touched.

I see.

I've run the tests locally, and everything is fine.

Cool

You can add the shared/ folder as a path that triggers the Python CI if you want.

I do want that :-)

You can add the shared/ folder as a path that triggers the Python CI if you want.

That ought to be fixed for all languages. Otherwise main will be broken by accident very soon.

That ought to be fixed for all languages. Otherwise main will be broken by accident very soon.

Every language has some implementation in shared/ now,. So yes, it's probably a good idea.

That ought to be fixed for all languages. Otherwise main will be broken by accident very soon.

I know how to do it for the CI workflows defined in github/codeql.
But I don't know how to do it for the internal CI jobs (Python is one of those).
@yoff: do you have experience with the internal CI jobs? Otherwise can you delegate to someone that does?

Edit: Looks like internal DX is on it, see below.

See also https://github.com/github/code-scanning-internal-dx-team/issues/87

@erik-krogh is anything blocking us from merging this? The above discussion about CI checks doesn't seem like it should block this particular PR.

@erik-krogh is anything blocking us from merging this? The above discussion about CI checks doesn't seem like it should block this particular PR.

No. I'll merge.