Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96848: Fix -X int_max_str_digits option parsing #96988

Merged
merged 1 commit into from Sep 26, 2022
Merged

gh-96848: Fix -X int_max_str_digits option parsing #96988

merged 1 commit into from Sep 26, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 21, 2022 •
edited by bedevere-bot

Fix code parsing the "-X int_max_str_digits" command line option when the PYTHONINTMAXSTRDIGITS environment variable is set to a valid limit.

@vstinner
Copy link
Member Author

@gpshead: Would you mind to review this fix for the issue #96848?

gpshead
gpshead reviewed Sep 22, 2022
View changes
Misc/NEWS.d/next/Core and Builtins/2022-09-21-14-38-31.gh-issue-96848.WuoLzU.rst Outdated
@@ -0,0 +1,3 @@
Fix code parsing the :option:`-X int_max_str_digits <-X>` command line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than "Fix" perhaps describe what the undesirable behavior was that is now no longer happening?

gpshead
gpshead approved these changes Sep 22, 2022
View changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment about the news entry, otherwise it looks good. backporting this also makes sense.

@vstinner
gh-96848: Fix -X int_max_str_digits option parsing
98c2554 
Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
@vstinner vstinner merged commit 4135166 into python:main Sep 26, 2022
14 checks passed
@vstinner
Copy link
Member Author

Thanks for the review, I adjusted the changelog entry.

@vstinner vstinner deleted the maxdigits_cmdline branch September 26, 2022 15:20
@vstinner vstinner added needs backport to 3.10 bug and security fixes needs backport to 3.11 bug and security fixes labels Sep 26, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-97571 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 bug and security fixes label Sep 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2022
@vstinner @miss-islington
pythongh-96848: Fix -X int_max_str_digits option parsing (pythonGH-96988
3f2527d 
)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 bug and security fixes label Sep 26, 2022
@bedevere-bot
Copy link

GH-97572 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2022
@vstinner @miss-islington
pythongh-96848: Fix -X int_max_str_digits option parsing (pythonGH-96988
e4284cb 
)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner added the needs backport to 3.9 only security fixes label Sep 26, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 26, 2022
@bedevere-bot
Copy link

GH-97574 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2022
@vstinner @miss-islington
pythongh-96848: Fix -X int_max_str_digits option parsing (pythonGH-96988
cc89be6 
)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner added the needs backport to 3.8 only security fixes label Sep 26, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-97575 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 26, 2022
@vstinner @miss-islington
pythongh-96848: Fix -X int_max_str_digits option parsing (pythonGH-96988
8dcc5b3 
)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner added the needs backport to 3.7 only security fixes label Sep 26, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 41351662bcd21672d8ccfa62fe44d72027e6bcf8 3.7

@bedevere-bot
Copy link

GH-97576 is a backport of this pull request to the 3.7 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 only security fixes label Sep 26, 2022
@vstinner
Copy link
Member Author

I created backports to 3.7-3.11 branches.

miss-islington added a commit that referenced this pull request Sep 26, 2022
@miss-islington @vstinner
gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)
a4ff0ea 
Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Sep 26, 2022
@miss-islington @vstinner
gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)
00c3524 
Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
ambv pushed a commit that referenced this pull request Oct 4, 2022
@miss-islington @vstinner
[3.8] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988) (G…
18a0cdb 
…H-97575)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
ambv pushed a commit that referenced this pull request Oct 4, 2022
@miss-islington @vstinner
[3.9] gh-96848: Fix -X int_max_str_digits option parsing (GH-96988) (G…
358b7a4 
…H-97574)

gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
ambv pushed a commit that referenced this pull request Oct 5, 2022
@vstinner
[3.7] gh-96848: Fix -X int_max_str_digits option parsing (#96988) (#9…
98884f5 
…7576)

Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.

(cherry picked from commit 4135166)
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
@miss-islington @vstinner @pablogsal
gh-96848: Fix -X int_max_str_digits option parsing (GH-96988)
67f5d24 
Fix command line parsing: reject "-X int_max_str_digits" option with
no value (invalid) when the PYTHONINTMAXSTRDIGITS environment
variable is set to a valid limit.
(cherry picked from commit 4135166)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @miss-islington @bedevere-bot @gpshead