Skip to content

Swift: Use asNominalTypeDecl more.#13223

Merged
MathiasVP merged 3 commits intogithub:mainfrom
geoffw0:useasnominaltypedecl
May 19, 2023
Merged

Swift: Use asNominalTypeDecl more.#13223
MathiasVP merged 3 commits intogithub:mainfrom
geoffw0:useasnominaltypedecl

Conversation

@geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented May 19, 2023

Use asNominalTypeDecl more:

  • to resolve methods and variables declared in extensions correctly. We've had models fail in both tests and real world query runs in the past because they were looking for something in a particular named type declaration, but that thing was actually in an extension of it.
  • to avoid needing special case disjuncts to do so.

Some of these changes could affect results, so I'll do a DCA run to be safe.

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Swift labels May 19, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner May 19, 2023 13:39
@geoffw0
Copy link
Contributor Author

geoffw0 commented May 19, 2023

DCA LGTM. No alert changes.

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MathiasVP MathiasVP merged commit 58f4b76 into github:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note Swift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants