Skip to content

Shared: Share autobuilder code between Ruby and QL#13029

Merged
hmac merged 1 commit intogithub:mainfrom
hmac:ruby-autobuilder-refactor
May 12, 2023
Merged

Shared: Share autobuilder code between Ruby and QL#13029
hmac merged 1 commit intogithub:mainfrom
hmac:ruby-autobuilder-refactor

Conversation

@hmac
Copy link
Contributor

@hmac hmac commented May 4, 2023

Add an autobuilder module to the shared extractor, which handles construction of the index-files command, including LGTM_INDEX_FILTERS env var parsing etc.

This reduces the autobuilder code in Ruby and QL to something close to the minimum.

@hmac hmac force-pushed the ruby-autobuilder-refactor branch 3 times, most recently from 2995a9f to 69e126a Compare May 5, 2023 07:17
@hmac hmac force-pushed the ruby-autobuilder-refactor branch from 69e126a to 9203efb Compare May 5, 2023 07:20
@hmac hmac added the no-change-note-required This PR does not need a change note label May 6, 2023
@hmac hmac marked this pull request as ready for review May 6, 2023 03:38
@hmac hmac requested review from a team as code owners May 6, 2023 03:38
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QL-for-QL 👍

@calumgrant calumgrant requested a review from aibaars May 9, 2023 08:35
@hmac hmac merged commit 48f2268 into github:main May 12, 2023
@hmac hmac deleted the ruby-autobuilder-refactor branch May 12, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note QL-for-QL Ruby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants