Misc: Add script to accept .expected changes from CI#12977
Merged
MathiasVP merged 6 commits intogithub:mainfrom May 17, 2023
Merged
Misc: Add script to accept .expected changes from CI#12977MathiasVP merged 6 commits intogithub:mainfrom
.expected changes from CI#12977MathiasVP merged 6 commits intogithub:mainfrom
Conversation
This script can be used to go over `codeql test run` expected/actual log output from actions CI checks for a PR, and apply patches locally to make the tests pass. Designed for use by GitHub employees, since it needs access to internal CI runs. Just run this tool while the branch for the PR is checked out! You need the `gh` cli tool installed and authenticated. Example can be seen in github#12950
Contributor
|
I haven't reviewed any of the code, but this totally did the Right Thing for the |
As requested by `@hvitved`
MathiasVP
approved these changes
May 17, 2023
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
I haven't studied the code in detail, but it has done the right thing on all the PRs I've tried. So this LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script can be used to go over
codeql test runexpected/actual logoutput from actions CI checks for a PR, and apply patches locally to
make the tests pass.
Designed for use by GitHub employees, since it needs access to internal CI runs. Just run this tool while the branch for the PR is checked out!
You need the
ghcli tool installed and authenticated.Example can be seen in #12950