Adding Rally App to Flutter Samples #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
August 13, 2019 14:22
Updating README file
Adding Basic Rally App
Adding Rally Pages
Rally Fonts and Charts
added 2 commits
September 3, 2019 13:51
RedBrogdon
requested changes
Sep 3, 2019
material_studies/rally/README.md
Outdated
|
|
||
| For info on the Rally Material Study, see: https://material.io/design/material-studies/rally.html | ||
|
|
||
| **This sample is not currently in a finished state. We're in the process |
There was a problem hiding this comment.
I think you can take this out now.
| } | ||
| } | ||
|
|
||
| void _drawXAxisLabels(Canvas canvas, Rect rect) { |
There was a problem hiding this comment.
This method could use a one-line comment like the one above.
| ), | ||
| ), | ||
| ListView(shrinkWrap: true, children: financialEntityCards) | ||
| ]); |
There was a problem hiding this comment.
nit: Separate with a comma for formatting.
| ); | ||
| } | ||
|
|
||
| FinancialEntityCategoryView fromAccountItem(AccountData model, int i) { |
There was a problem hiding this comment.
These three methods need to be renamed similar to the ones below (build...).
| }, | ||
| child: ListView( | ||
| padding: EdgeInsets.symmetric(horizontal: 24), | ||
| children: <Widget>[ |
| @override | ||
| Widget build(BuildContext context) { | ||
| double balanceTotal = sumAccountDataPrimaryAmount(items); | ||
| List<RallyPieChartSegment> segments = fromAccountItems(items); |
There was a problem hiding this comment.
This local doesn't need to exist. It can just be inlined on line 33.
| @override | ||
| Widget build(BuildContext context) { | ||
| double dueTotal = sumBillDataPrimaryAmount(items); | ||
| List<RallyPieChartSegment> segments = fromBillItems(items); |
There was a problem hiding this comment.
Similarly to the comment above, this can just be inlined.
| Widget build(BuildContext context) { | ||
| double capTotal = sumBudgetDataPrimaryAmount(items); | ||
| double usedTotal = sumBudgetDataAmountUsed(items); | ||
| List<RallyPieChartSegment> segments = fromBudgetItems(items); |
RedBrogdon
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.