Add game_template #1180
Add game_template #1180
Conversation
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.security.app-sandbox</key> |
There was a problem hiding this comment.
Does the app need network access in prod?
There was a problem hiding this comment.
It does, for Crashlytics.
|
Thanks for the reviews, @domesticmouse and @parlough! I think I addressed all issues but there are some discussions I left unresolved. Feel free to either close them or continue. |
|
I'm happy to land this as is, and fast follow changes as required. @parlough is there anything outstanding from your point of view? |
|
Looks good to me. The required 2.17 changes and anything else can be completed in the future as needed :) |
| device attached. | ||
|
|
||
| It is often convenient to develop your game as a desktop app. | ||
| For example, you can run `flutter run -d macOS`, and get the same UI |
There was a problem hiding this comment.
You don't have to use the macOS tag once we hit stable. Also, that wouldn't work at all if you're on Windows or Linux. I'd reword this sentence.
game_template/analysis_options.yaml
Outdated
| rules: | ||
| # Remove or force lint rules by adding lines like the following. | ||
| # The lints below are disabled in order to make things smoother in early | ||
| # development. You might want to enable them once things stabilize. |
There was a problem hiding this comment.
| # development. You might want to enable them once things stabilize. | |
| # development. Consider enabling them once development is further along. |
| GeneratedPluginRegistrant.java | ||
|
|
||
| # Remember to never publicly share your keystore. | ||
| # See https://flutter.dev/docs/deployment/android#reference-the-keystore-from-the-app |
There was a problem hiding this comment.
It's SUPER interesting that the anchor in your original URL didn't work. I assume it has to do with using a flutter.dev URL rather than a docs.flutter.dev URL...
| # See https://flutter.dev/docs/deployment/android#reference-the-keystore-from-the-app | |
| # For more info, check out | |
| # [Reference the keystore from the app](https://docs.flutter.dev/deployment/android#reference-the-keystore-from-the-app). |
There was a problem hiding this comment.
These things (like .gitignore) come from Flutter SDK itself. For example: https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app_shared/android.tmpl/.gitignore.
I haven't touched these files. This is what all apps are created with.
| @@ -0,0 +1,10 @@ | |||
| # This file tracks properties of this Flutter project. | |||
| # Used by Flutter tool to assess capabilities and perform upgrades etc. | |||
There was a problem hiding this comment.
| # Used by Flutter tool to assess capabilities and perform upgrades etc. | |
| # The Flutter tool uses this info to assess capabilities and perform upgrades. |
|
@filiph can you please update your PR to merge in the changes we have landed in master? |
As per Brett’s suggestion and https://dart.dev/guides/language/effective-dart/usage#prefer-relative-import-paths.
We should be able to call awardAchievement (and submitLeaderboardScore) indiscriminately, without checking whether we’re signed in or not. Right now, this produces a severe log message that sends this information to crashlytics.
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
This leads to a crash on startup. Isolates are not supported in the browser.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
|
@domesticmouse - Did this now. The current run fails with "Verify web demos", though. I'm going to wait for a bit, and try again later today. But since the web demos are completely separate from |
|
Yup, the failing test is known. @craiglabenz is working on it, I believe. @sfshaza2 you should now have your |
Adds a template / sample for games built in Flutter, with all the bells and whistles, like ads, in-app purchases, audio, main menu, settings, and so on.
// cc @domesticmouse @craiglabenz
Pre-launch Checklist
///).