Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable linters now that golangci-lint has been updated #5615

Merged
merged 1 commit into from May 11, 2022
Merged

Re-enable linters now that golangci-lint has been updated #5615

merged 1 commit into from May 11, 2022

Conversation

samcoe
Copy link
Member

@samcoe samcoe commented May 11, 2022 •
edited

When upgrading to Go 1.18 we disabled some linters because they were not supported yet. They are supported in the new version of golangci-lint so this PR upgrades to the newest version and re-enables the disabled linters.

cc #5542

@samcoe samcoe self-assigned this May 11, 2022
@samcoe samcoe marked this pull request as ready for review May 11, 2022 14:48
@samcoe samcoe requested a review from a team as a code owner May 11, 2022 14:48
@samcoe samcoe requested review from mislav and removed request for a team May 11, 2022 14:48
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI May 11, 2022
mislav
mislav approved these changes May 11, 2022
View changes
Copy link
Member

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; thank you

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 May 11, 2022
@samcoe samcoe merged commit 06fb78a into trunk May 11, 2022
10 checks passed
@samcoe samcoe deleted the update-lint branch May 11, 2022 14:57
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 May 11, 2022
@samcoe samcoe mentioned this pull request May 12, 2022
Merged
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mislav mislav mislav approved these changes

Assignees

@samcoe samcoe

Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samcoe @mislav