Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Table of Error Codes to Docs #3202

Merged
merged 6 commits into from May 10, 2023
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented May 1, 2023

This PR takes the friendly error messages from Errors.cpp and puts them into a table with the corresponding return response.

Also related to -


Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner May 1, 2023 20:44
@github-actions

This comment has been minimized.

Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add a link to this file in Troubleshooting Guide for easier discovery.

doc/windows/package-manager/winget/returnCodes.md Outdated Show resolved Hide resolved
doc/windows/package-manager/winget/returnCodes.md Outdated Show resolved Hide resolved
doc/windows/package-manager/winget/returnCodes.md Outdated Show resolved Hide resolved
doc/windows/package-manager/winget/returnCodes.md Outdated Show resolved Hide resolved
Trenly and others added 3 commits May 2, 2023 20:38
Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
@yao-msft
Copy link
Contributor

yao-msft commented May 9, 2023

Not sure how this doc will be maintainable. But please update the messages from the other pr before this was merged

@Trenly
Copy link
Contributor Author

Trenly commented May 10, 2023

Not sure how this doc will be maintainable.

I don't think it will be super maintainable, especially given that the file in the other PR was missing several error codes. Since it was the community who asked for a mapping of the error codes, I would presume it would be primarily community maintained

But please update the messages from the other pr before this was merged

Updated

@yao-msft yao-msft merged commit f7182f8 into microsoft:master May 10, 2023
4 checks passed
@Trenly Trenly deleted the ErrorCodesDoc branch May 11, 2023 14:22
This was linked to issues May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Exit Codes document error codes used by winget
4 participants