Put required modules into the repo and consume them in dev scenarios #3103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
msftrubengu
approved these changes
Mar 23, 2023
| // Assume that the additional modules path is a sibling directory to the one containing this binary | ||
| string assemblyDirectory = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location) ?? throw new InvalidDataException(); | ||
| string rootDirectory = Path.GetDirectoryName(assemblyDirectory) ?? throw new InvalidDataException(); ; | ||
| string modulesPath = Path.Combine(rootDirectory, "ExternalModules"); |
There was a problem hiding this comment.
maybe we should log if it doesnt exist, just to know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change
Adds the newer version of
PowerShellGet(and its dependencies) that isn't installed by default on Windows so that a clean machine can build and run the dev package and tests. Changes the tests and dev package to consume the modules as well.This change also updates the CI pipeline to produce a full package layout for testing. This will enable the full package experience to be tested in the end-to-end tests.
Validation
Tests working locally, dev package working locally, in absence of newer version of module.
Microsoft Reviewers: Open in CodeFlow