C#: Re-factor ContentFlow to a parameterised module and use the new API.#12952
Merged
michaelnebel merged 3 commits intogithub:mainfrom May 1, 2023
Merged
Conversation
04ddeab to
8517f11
Compare
hvitved
requested changes
Apr 27, 2023
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Looks great! A few minor suggestions.
csharp/ql/lib/semmle/code/csharp/dataflow/internal/ContentDataFlow.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/internal/ContentDataFlow.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/internal/ContentDataFlow.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/dataflow/internal/ContentDataFlow.qll
Outdated
Show resolved
Hide resolved
59e070b to
36ea61c
Compare
hvitved
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we re-factor the ContentFlow dataflow library.
I have assumed that this is not being used externally as it was mode for experimental purposes (to be used with the model generator) and internally we only have a unit test that relies on this implementation.