Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby/QL: Merge extractor binaries #12786

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Ruby/QL: Merge extractor binaries #12786

wants to merge 8 commits into from
+664 −358

Conversation

hmac
Copy link
Contributor

@hmac hmac commented Apr 7, 2023 •
edited

Currently the Ruby and QL extractors consist of three binaries: extractor, autobuilder and generator. This PR merges them into a single binary, codeql-ruby-extractor, which takes a positional argument specifying what to do.

CodeQL Ruby extractor

Usage: codeql-ruby-extractor <COMMAND>

Commands:
  extract
  generate
  autobuild
  help       Print this message or the help of the given subcommand(s)

Options:
  -h, --help     Print help
  -V, --version  Print version

The flags are identical to the old binaries:

Usage: codeql-ruby-extractor extract --source-archive-dir <SOURCE_ARCHIVE_DIR> --output-dir <OUTPUT_DIR> --file-list <FILE_LIST>

Options:
      --source-archive-dir <SOURCE_ARCHIVE_DIR>
          Sets a custom source achive folder
      --output-dir <OUTPUT_DIR>
          Sets a custom trap folder
      --file-list <FILE_LIST>
          A text file containing the paths of the files to extract
  -h, --help
          Print help


Usage: codeql-ruby-extractor autobuild

Options:
  -h, --help  Print help


Usage: codeql-ruby-extractor generate --dbscheme <DBSCHEME> --library <LIBRARY>

Options:
      --dbscheme <DBSCHEME>  Path of the generated dbscheme file
      --library <LIBRARY>    Path of the generated QLL file
  -h, --help                 Print help

@hmac hmac force-pushed the merge-extractor-binaries branch from 491938e to 48fd4bf Compare April 7, 2023 03:58
hmac added 3 commits April 7, 2023 12:04
@hmac
Ruby: Enable derive feature in clap
5a8a6f2 
This allows nicer CLI definitions.
@hmac
Ruby: Merge extractor binaries into one
79089b4 
There is now one binary, codeql-ruby-extractor, which takes a positional
argument specifying whether to extract, generate or autobuild.
@hmac
QL: Enable derive feature in clap
e4b4d8a 
This allows nicer CLI definitions.
@hmac hmac force-pushed the merge-extractor-binaries branch from 48fd4bf to daa0c31 Compare April 7, 2023 04:15
hmac added 4 commits April 7, 2023 15:49
@hmac
QL: Merge extractor binaries into one
eff4729 
There is now one binary, codeql-ql-extractor, which takes a positional
argument specifying whether to extract, generate or autobuild.
@hmac
QL: Update scripts for merged extractor
c139991
@hmac
Ruby: Update scripts for merged extractor
d942b54
@hmac
Ruby/QL: Remove unnecessary CLI config
2ef6d5c
@hmac hmac force-pushed the merge-extractor-binaries branch from daa0c31 to 2ef6d5c Compare April 7, 2023 07:49
@hmac
Ruby: Re-add test
8691845 
This got lost in an earlier refactor.
@hmac hmac marked this pull request as ready for review April 7, 2023 09:32
@hmac hmac requested review from a team as code owners April 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-ruby codeql-ruby

@github/codeql-ql-for-ql-reviewers codeql-ql-for-ql-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
QL-for-QL Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hmac