Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add execution permission to uvwasi script #47600

Merged
merged 1 commit into from Apr 19, 2023
Merged

tools: add execution permission to uvwasi script #47600

merged 1 commit into from Apr 19, 2023
+0 −0

Conversation

mertcanaltin
Copy link
Contributor

@mertcanaltin mertcanaltin commented Apr 17, 2023 •
edited

After talking to anonrig, I realized that it was a permission error. I typed chmod +x and ran it and sent it
issue
cc @anonrig for keeping him in the loop

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 17, 2023
@bnb
Copy link
Member

bnb commented Apr 17, 2023

is there context on why this is needed? 👀

@mertcanaltin
Copy link
Contributor Author

mertcanaltin commented Apr 17, 2023 •
edited

is there context on why this is needed? 👀

we were encountering permission error
https://github.com/nodejs/node/actions/runs/4710514618/jobs/8354227917

anonrig
anonrig approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up. 👍

@anonrig
Copy link
Member

anonrig commented Apr 17, 2023

@mertcanaltin Can you write a descriptive description to your PR and the command you executed to fix the issue, and provide a link to the original issue?

@mertcanaltin mertcanaltin changed the title tools: uvwasi update tools: add execution permission to uvwasi script Apr 17, 2023
@anonrig
Copy link
Member

anonrig commented Apr 17, 2023

cc @nodejs/actions

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2023
@targos
Copy link
Member

targos commented Apr 18, 2023

Refs: #47597

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2023
@mertcanaltin mertcanaltin mentioned this pull request Apr 18, 2023
Open
mhdawson
mhdawson approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 19, 2023
@github-actions

This comment was marked as off-topic.

Sign in to view
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2023
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit f509f10 into nodejs:main Apr 19, 2023
35 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in f509f10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@mertcanaltin @bnb @anonrig @targos @nodejs-github-bot @lpinca @tniessen @mhdawson @marco-ippolito