New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gcloud because it's resolved to a .ps1 script
#18575
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
/backport to release/v7.3.1 |
PR Summary
This is a follow-up PR of #18559
It turns out
glcoudis resolved togcloud.ps1which is under the installation folder. Withingcloud.ps1,python.exeis eventually called to do the actual work.Adding
glcoudto the list won't solve the problem because it's not a native command. So, remove it.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.