Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DllImport with LibraryImport in SMA 3 #18564

Merged
merged 5 commits into from Nov 29, 2022
Merged

Replace DllImport with LibraryImport in SMA 3 #18564

merged 5 commits into from Nov 29, 2022

Conversation

iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Nov 15, 2022 •
edited

PR Summary

Contributes to #18553.

I did not find how test this and did manual test for the pinvoke. I can add real test in the PR if anybody helps.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 15, 2022
SteveL-MSFT
SteveL-MSFT reviewed Nov 21, 2022
View changes
src/System.Management.Automation/engine/Interop/Windows/FindExecutable.cs Outdated
{
resultCode = FindExecutableW(filename, string.Empty, lpBuffer);

// If FindExecutable returns a result >= 32, then it succeeded
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say this should be result > 32 as == 32 is an error: https://learn.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-findexecutablew#return-value. Looks like the old code was wrong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@msftbot msftbot bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 21, 2022
@msftbot msftbot bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 21, 2022
@pull-request-quantifier
Copy link

This PR has 49 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +28 -21
Percentile : 19.6%

Total files changed: 2

Change summary by file extension:
.cs : +28 -21

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov merged commit 8686612 into PowerShell:master Nov 29, 2022
40 checks passed
@iSazonov iSazonov deleted the libraryimport-sma3 branch November 29, 2022 03:08
@msftbot
Copy link

msftbot bot commented Dec 20, 2022

🎉v7.4.0-preview.1 has been released which incorporates this pull request.🎉

Handy links:

CarloToso pushed a commit to CarloToso/PowerShell that referenced this pull request Jan 15, 2023
@iSazonov @CarloToso
Replace DllImport with LibraryImport in SMA 3 (PowerShell#18564)
83992fb
gregsdennis pushed a commit to gregsdennis/PowerShell that referenced this pull request Mar 15, 2023
@iSazonov @gregsdennis
Replace DllImport with LibraryImport in SMA 3 (PowerShell#18564)
8327555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@daxian-dbw daxian-dbw

Assignees

@iSazonov iSazonov

Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iSazonov @SteveL-MSFT @adityapatwardhan