Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Switch-Process error to include the command that is not found #18443

Merged
merged 2 commits into from Nov 3, 2022
Merged

Fix Switch-Process error to include the command that is not found #18443

merged 2 commits into from Nov 3, 2022

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Nov 2, 2022 •
edited

PR Summary

The formatting of the error was incorrectly using the wrong variable which would be null. Fix is to use the first item in the input which is the command name.

Had to increase timeout in a test that kept failing with multiple reruns.

PR Context

Fix #18436

PR Checklist

@pull-request-quantifier
Copy link

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +8 -3
Percentile : 4.4%

Total files changed: 3

Change summary by file extension:
.cs : +3 -3
.ps1 : +5 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov merged commit 52a62e9 into PowerShell:master Nov 3, 2022
40 checks passed
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 3, 2022
@SteveL-MSFT SteveL-MSFT deleted the switchprocess-error branch November 3, 2022 13:56
@daxian-dbw
Copy link
Member

/backport to release/v7.3.1

@github-actions
Copy link
Contributor

@daxian-dbw backporting to release/v7.3.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix `Switch-Process` error to include the command that is not found
Using index info to reconstruct a base tree...
M	src/System.Management.Automation/engine/Modules/SwitchProcessCommand.cs
M	test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1
Falling back to patching base and 3-way merge...
Auto-merging test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1
CONFLICT (content): Merge conflict in test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1
Auto-merging src/System.Management.Automation/engine/Modules/SwitchProcessCommand.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix `Switch-Process` error to include the command that is not found
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Nov 22, 2022
@SteveL-MSFT @daxian-dbw
Fix Switch-Process error to include the command that is not found (P…
be61593 
…owerShell#18443)
@daxian-dbw daxian-dbw mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw

@iSazonov iSazonov

Assignees

@iSazonov iSazonov

Labels
Backport-7.3.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch-Process: broken error message if the executable cannot be found
4 participants
@SteveL-MSFT @daxian-dbw @iSazonov @adityapatwardhan