New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webcmdlets set default charset encoding to UTF8 #18219
Conversation
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Outdated
Show resolved
Hide resolved
It had 0 references, it was never used
...rosoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/ContentHelper.Common.cs
Outdated
Show resolved
Hide resolved
...rosoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/ContentHelper.Common.cs
Outdated
Show resolved
Hide resolved
...rosoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/ContentHelper.Common.cs
Outdated
Show resolved
Hide resolved
|
@SteveL-MSFT I think the PR makes sense but we need WG/Committee conclusion since we are moving away from RFC standard. |
|
@SteveL-MSFT do you have any updates? |
|
@CarloToso Please fix tests. |
|
@CarloToso You should sign CLA before we can merge. |
|
It seems the cla-bot is broken (https://cla.microsoft.com/ gives 403 error) |
|
@microsoft-github-policy-service agree |
|
@SteveL-MSFT Please update you review. |
|
Marking Cmdlet WG to review. |
|
Added to WG queue |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
@PowerShell/wg-powershell-cmdlets reviewed this and compared the behavior to curl which correctly handles the UTF-8 BOM so we agree that the default should be UTF-8 instead of Ascii" |
|
@CarloToso Thanks for your contribution! |
|
@iSazonov Thank you for your guidance |
PR Summary
Changes the default charset encoding of webcmdlets from Ascii to UTF8
It's just a small fix, it does not solve BOM related problems #11547
PR Context
Fixes #10971
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).