New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make experimental feature PSAnsiRenderingFileInfo stable
#18042
Make experimental feature PSAnsiRenderingFileInfo stable
#18042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
/backport to release/v7.3.0-rc.1 |
|
Handy links: |
PR Summary
PS-Committee had reviewed this along with the feedback. Make stable to get more user feedback. Since the decoration is user configurable, users can turn it off completely or adjust. The main criteria here is to enable this capability and less about the default colors which are user configurable. We appreciate the feedback (although would have liked it to come earlier) and agreed that since formatting changes are not breaking changes, we should proceed with the current defaults and we can continue discussing with the community potential changes for the defaults in 7.4 previews.
PR Context
Per #17962 making this experimental feature stable for 7.3
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).