New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pwsh server modes implicitly not show banner or profile load times
#17921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
Outdated
Show resolved
Hide resolved
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
Handy links: |
PR Summary
Currently, if you use one of the server mode switches with
pwsh, it will still emit the banner unless you suppress it with-nologo. So in our docs, we always include-nologowhen using a server mode switch. The logo will cause problems because in server mode, the client expects to only receive remote message payloads and not the banner text. Change is to not emit the banner nor the profile load time if using one of the various server modes.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.-nologowhen used with server modes MicrosoftDocs/PowerShell-Docs#9141(which runs in a different PS Host).