New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not preserve temporary results when no need to do so #17856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One minor comment suggestion
Also updated the disasm from this build in the disasm gist
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
|
/remind me tomorrow |
|
@TravisEz13 set a reminder for 8/9/2022 |
|
|
|
Should we document this as a breaking change (formally at least)? |
PR Summary
Fix #17836
Do not preserve temporary results when no need to do so.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.